Skip to content

For apisupport.ant, don't try to use the nbjdk.bootclasspath ant property, but rather take nbjdk.home, and take the JDK's bootstrap classpath. - #9432

Merged
lahodaj merged 1 commit into
apache:masterfrom
lahodaj:apisupport-ant-project-module-boot-path
Jul 15, 2026
Merged

For apisupport.ant, don't try to use the nbjdk.bootclasspath ant property, but rather take nbjdk.home, and take the JDK's bootstrap classpath.#9432
lahodaj merged 1 commit into
apache:masterfrom
lahodaj:apisupport-ant-project-module-boot-path

Conversation

@lahodaj

@lahodaj lahodaj commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

If I open in a recent build a current source for e.g. <netbeans>/platform/openide.util, I'll get notices like:

Even though the source level of /home/jlahoda/src/nb/netbeans/platform/openide.util.lookup/src:/home/jlahoda/src/nb/netbeans/platform/openide.util.lookup/build/classes-generated is set to: 17, java.lang.AssertionError cannot be found on the bootclasspath: /usr/lib/jvm/java-21-openjdk-amd64/jre/lib/rt.jar

in the log. Looking at the boot class path, that's not really surprising:

/usr/lib/jvm/java-21-openjdk-amd64/jre/lib/rt.jar

there is obviously no rt.jar in the JDK 21 installation, so the search for j.l.AssertionError fails.

This PR tries to fix the apisupport projects boot and module boot path, based on the nbjdk.home property. It will create a (transient) Java platform if there's no Java platform with the given install directory.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB31 milestone Jun 8, 2026
@lahodaj
lahodaj requested a review from dbalek June 8, 2026 06:55
@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Jun 8, 2026
@lahodaj
lahodaj marked this pull request as ready for review June 8, 2026 06:56
@mbien mbien added the Ant [ci] enable "build tools" tests label Jun 20, 2026
@mbien

mbien commented Jun 20, 2026

Copy link
Copy Markdown
Member

added ant label and restarting tests since apisupport.ant is part of the build tools job

@apache apache locked and limited conversation to collaborators Jun 20, 2026
@apache apache unlocked this conversation Jun 20, 2026

@dbalek dbalek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jul 13, 2026
@mbien

mbien commented Jul 13, 2026

Copy link
Copy Markdown
Member

@lahodaj could you rebase this PR? Probably something we could merge for NB31.

…erty, but rather take nbjdk.home, and take the JDK's bootstrap classpath.
@lahodaj
lahodaj force-pushed the apisupport-ant-project-module-boot-path branch from 6cb3cb6 to 9bb6f73 Compare July 14, 2026 08:19
@lahodaj

lahodaj commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

OK to merge?

@ebarboni

Copy link
Copy Markdown
Contributor

LGTM was about merging it but just go

@lahodaj
lahodaj merged commit 853a025 into apache:master Jul 15, 2026
141 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ant [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants