Skip to content

Address bug 127942#251

Merged
ardovm merged 3 commits intotrunkfrom
bug127942
Feb 8, 2025
Merged

Address bug 127942#251
ardovm merged 3 commits intotrunkfrom
bug127942

Conversation

@ardovm
Copy link
Contributor

@ardovm ardovm commented Jan 19, 2025

See bug 127942 for information.

ardovm added 2 commits January 19, 2025 22:16
@ardovm
File and URL history elements disappear when cleared
afd9e31 
Allow configuration elements to disappear by becoming "wiped"-type
nodes.
Intercept the removal of file and URL history elements and turn them into
"wiped" nodes.
@ardovm
Clear URL history together with recent files
8eeb065
@Pilot-Pirx Pilot-Pirx self-requested a review January 24, 2025 14:28
@Pilot-Pirx
Copy link
Member

Pilot-Pirx commented Jan 24, 2025

Windows build went fine.
But after clearing the recent file list the URL history is still populated...
After closing and reopening the URL history is clean.

@ardovm
Copy link
Contributor Author

ardovm commented Jan 24, 2025

There are other problems, unfortunately. When the history is cleared, it does not get populated again (visited documents are not saved) until the program is restarted.
This cannot be merged as is.

@ardovm ardovm marked this pull request as draft January 24, 2025 23:23
@ardovm
Revert "wiped" nodes and avoid saving history elements
13d3b75 
Avoid recording "removed" elements with certain paths, corresponding to
histories.

The KIND_WIPED nodes were a bad idea as they just created confusion.
Configuration element must be removed, not replaced.
@ardovm ardovm marked this pull request as ready for review January 27, 2025 22:05
@ardovm
Copy link
Contributor Author

ardovm commented Jan 27, 2025

Logic changed: configuration elements are removed as usual, but if their "parent path" matches the history settings, they are not saved as "removed".

@ardovm
Copy link
Contributor Author

ardovm commented Jan 27, 2025

[...] But after clearing the recent file list the URL history is still populated... After closing and reopening the URL history is clean.

Apparently, configuration file registrymodifications.xcu is saved asynchronously. It may take some (seconds? minutes?) after the user clears the history, for the file to be written to disk.

@Pilot-Pirx
Copy link
Member

Pilot-Pirx commented Jan 27, 2025

Apparently, configuration file registrymodifications.xcu is saved asynchronously. It may take some (seconds? minutes?) after the user clears the history, for the file to be written to disk.

Maybe that can be forced somehow?

@Pilot-Pirx
Copy link
Member

Pilot-Pirx commented Jan 31, 2025

I will try a new build this weekend.

@Pilot-Pirx
Copy link
Member

Pilot-Pirx commented Feb 5, 2025

New build behaves much better now!
Looks good to me...

@Pilot-Pirx
Copy link
Member

Pilot-Pirx commented Feb 7, 2025

If anyone wants to test:
https://www.dropbox.com/scl/fi/359ldyoz43bee32nhwwun/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_bug127942.exe?rlkey=5bsuwo2gvqiq9ixmd4copmfxh&st=1ket39dk&dl=0

@pedlino
Copy link
Contributor

pedlino commented Feb 7, 2025

Just downloaded and tested your 4.5 Windows build. It deletes all past entries, not only the Picklist (10 most recent) but the whole URL list (I use History Master on a daily basis). Is this intended?

@Pilot-Pirx
Copy link
Member

Pilot-Pirx commented Feb 7, 2025

Yes, that's what the issue is about.

@pedlino
Copy link
Contributor

pedlino commented Feb 7, 2025

Yes, that's what the issue is about.

Then, it looks good for me too :)

@ardovm ardovm merged commit 16169b2 into trunk Feb 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pilot-Pirx Pilot-Pirx Pilot-Pirx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ardovm @Pilot-Pirx @pedlino