pre-commit(end-of-file-fixer): autofix XML files#351
Conversation
|
You cant just create a PR with 433 changed files and not provide a description of what you did and why - please do that, and for all future PRs please |
|
Hello @gmcdonald if you have been following the last 3+ months or so of development of Apache OpenOffice you will in fact see that many PRs have been merged with this same format.
@Pilot-Pirx and I have been working together to develop a pre-commit framework and the description of what has been changed really is in the commit message. These are official pre-commit hooks and they are used on many ASF projects. https://github.com/pre-commit/pre-commit-hooks When the hooks were first added there was a lot more information and descriptions about them. For example #261 Is there really any need to write up more ? |
|
All PRs should have descriptions, that what the field is there for. Yes I have been following along, as a PMC member I do take an interest. |
|
From time to time GitHub and GitBox do not synchronize... |
(cherry picked from commit ef208b1)
Makes sure files end in a newline and only a newline.
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#end-of-file-fixer