Skip to content

pre-commit(end-of-file-fixer): autofix XML files#351

Merged
Pilot-Pirx merged 1 commit intoapache:trunkfrom
jbampton:pre-commit-clean-up
Apr 1, 2025
Merged

pre-commit(end-of-file-fixer): autofix XML files#351
Pilot-Pirx merged 1 commit intoapache:trunkfrom
jbampton:pre-commit-clean-up

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Apr 1, 2025

Makes sure files end in a newline and only a newline.

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#end-of-file-fixer

@gmcdonald
Copy link

You cant just create a PR with 433 changed files and not provide a description of what you did and why - please do that, and for all future PRs please

@jbampton
Copy link
Member Author

jbampton commented Apr 1, 2025

Hello @gmcdonald if you have been following the last 3+ months or so of development of Apache OpenOffice you will in fact see that many PRs have been merged with this same format.

@Pilot-Pirx and I have been working together to develop a pre-commit framework and the description of what has been changed really is in the commit message.

These are official pre-commit hooks and they are used on many ASF projects.

https://github.com/pre-commit/pre-commit-hooks

When the hooks were first added there was a lot more information and descriptions about them.

For example #261

Is there really any need to write up more ?

@gmcdonald
Copy link

All PRs should have descriptions, that what the field is there for.

Yes I have been following along, as a PMC member I do take an interest.

@Pilot-Pirx Pilot-Pirx merged commit ef208b1 into apache:trunk Apr 1, 2025
1 check passed
@jbampton jbampton deleted the pre-commit-clean-up branch April 1, 2025 12:38
@Pilot-Pirx
Copy link
Member

From time to time GitHub and GitBox do not synchronize...
Like just now. Then I have to do another small change to get it in sync.

asfgit pushed a commit that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants