Skip to content

Catch invalid parameters detected by the Win32 runtime library #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ardovm merged 1 commit into from
Dec 13, 2025
Merged

Catch invalid parameters detected by the Win32 runtime library #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions main/sal/osl/w32/signal.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,25 @@ static oslSignalHandlerImpl* SignalList;

static long WINAPI SignalHandlerFunction(LPEXCEPTION_POINTERS lpEP);

static _invalid_parameter_handler pPreviousInvalidParameterHandler = NULL;
static void InvalidParameterHandlerFunction(
const wchar_t* expression,
const wchar_t* function,
const wchar_t* file,
unsigned int line,
uintptr_t pReserved );

static sal_Bool InitSignal(void)
{
HMODULE hFaultRep;

SignalListMutex = osl_createMutex();

SetUnhandledExceptionFilter(SignalHandlerFunction);
if ( pPreviousInvalidParameterHandler == NULL )
{
pPreviousInvalidParameterHandler = _set_invalid_parameter_handler( InvalidParameterHandlerFunction );
}

hFaultRep = LoadLibrary( "faultrep.dll" );
if ( hFaultRep )
Expand All @@ -78,6 +90,11 @@ static sal_Bool DeInitSignal(void)
{
SetUnhandledExceptionFilter(NULL);

if ( pPreviousInvalidParameterHandler )
{
_set_invalid_parameter_handler( pPreviousInvalidParameterHandler );
pPreviousInvalidParameterHandler = NULL;
}
osl_destroyMutex(SignalListMutex);

return sal_False;
Expand Down Expand Up @@ -320,6 +337,36 @@ static long WINAPI SignalHandlerFunction(LPEXCEPTION_POINTERS lpEP)
return (EXCEPTION_CONTINUE_EXECUTION);
}

static void InvalidParameterHandlerFunction(
const wchar_t* expression,
const wchar_t* function,
const wchar_t* file,
unsigned int line,
uintptr_t pReserved )
{
oslSignalInfo Info;

fwprintf(stderr, L"Invalid parameter detected in function %s.\n"
L"File: %s\n"
L"Line: %u\n"
L"Expression: %s\n"
L"pReserved: %p\n", function, file, line, expression, pReserved);

Info.Signal = osl_Signal_AccessViolation;
Info.UserSignal = 0;
Info.UserData = NULL;
if ( ReportCrash( NULL ) || IsWin95A() )
{
CallSignalHandler(&Info);
abort(); // Equivalent of osl_Signal_ActAbortApp
} else {
// Equivalent of osl_Signal_ActKillApp
SetErrorMode(SEM_NOGPFAULTERRORBOX);
exit(255);
}
// We will never reach this point
}

/*****************************************************************************/
/* osl_addSignalHandler */
/*****************************************************************************/
Expand Down