add pytest and types-pyyaml dev deps to Python package - #295
Open
averms wants to merge 1 commit into
Open
Conversation
The former is needed to run tests and the latter is needed for type checking with mypy.
There was a problem hiding this comment.
Pull request overview
Adds missing Python development dependencies for the python/ package so contributors can run the existing test suite (pytest) and perform stricter type-checking around YAML usage (types-PyYAML), consistent with the repo’s broader uv-based workflow.
Changes:
- Add a
devdependency group containingpytestandtypes-pyyamltopython/pyproject.toml. - Regenerate
python/uv.lockto include the new dev dependencies and their resolved transitive packages.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/pyproject.toml | Introduces a dev dependency group for local testing/type-checking dependencies. |
| python/uv.lock | Updates the lockfile to include the newly added dev dependencies and their resolved tree. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+47
| [dependency-groups] | ||
| dev = [ | ||
| "pytest>=9.1.1", | ||
| "types-pyyaml>=6.0.12.20260724", | ||
| ] |
Author
There was a problem hiding this comment.
i think this is incorrect. uv sync for me does install group dev
There was a problem hiding this comment.
Yep, verified that uv sync works with a fresh setup:
→ uv sync
Using CPython 3.14.3
Creating virtual environment at: .venv
Resolved 14 packages in 15ms
Built apache-ossie @ file:///Users/81045729/Documents/constant_variables/ossie/python
Prepared 2 packages in 893ms
Installed 13 packages in 32ms
+ annotated-types==0.7.0
+ apache-ossie==0.2.0.dev0 (from file:///Users/81045729/Documents/constant_variables/ossie/python)
+ iniconfig==2.3.0
+ packaging==26.2
+ pluggy==1.6.0
+ pydantic==2.13.4
+ pydantic-core==2.46.4
+ pygments==2.20.0
+ pytest==9.1.1
+ pyyaml==6.0.3
+ types-pyyaml==6.0.12.20260724
+ typing-extensions==4.16.0
+ typing-inspection==0.4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The former is needed to run tests and the latter is needed for type checking with mypy.
Specifically, without types-pyyaml,
mypy --strict .gives the errors:Related Issues
Checklist
Tests
pytest/ CI green)Compliance
I guess a third-party dependency was added, https://pypi.org/project/types-PyYAML/