[OSSIE][NVIDIA_GSF] Rename GSF converter directory and package to NVIDIA - #299
Open
liofnv wants to merge 1 commit into
Open
[OSSIE][NVIDIA_GSF] Rename GSF converter directory and package to NVIDIA#299liofnv wants to merge 1 commit into
liofnv wants to merge 1 commit into
Conversation
Name the converter after the vendor that owns it rather than the product, matching how every other converter directory in the tree is named. The directory becomes converters/nvidia and the import package becomes ossie_nvidia_gsf, so the product name still appears at the point of import. Rename the distribution to apache-ossie-nvidia-gsf and the console script to ossie-nvidia-gsf, and repoint the CI workflow, itself renamed to converter-nvidia-ci.yml to preserve the converter-<dir>-ci.yml convention shared by the other converters. Its check name changes accordingly. The NVIDIA_GSF vendor code in the spec's extension table is left alone, being a format identifier rather than a path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names the converter after the vendor that owns it, matching how the other converter directories are named.
converters/gsf→converters/nvidia,src/ossie_gsf→src/ossie_nvidia_gsfapache-ossie-gsf→apache-ossie-nvidia-gsf, scriptossie-gsf→ossie-nvidia-gsfconverter-nvidia-ci.ymlto keep theconverter-<dir>-ci.ymlconventionNo behavior change. All moves are recorded as git renames.