feat: add IVF-SQ L2 distance range search - #106
Merged
Merged
Conversation
jerry-024
reviewed
Sep 16, 2026
jerry-024
reviewed
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #97. Adds IVF-SQ L2 distance range search on top of current
main, including the already-merged IVF-RQ support from #104.DistanceBand,VectorRangeSearchParams,RangeSearchResult, and the genericCollectorscan seam. Membership is decided by the same blocked SQ-estimated squared-L2 values used by the SQ scanner, not original-vector distances or a capped top-K fallback.Performance
Coverage
Validation
Executed locally after rebasing onto
c2d9436:cargo fmt --all -- --checkcargo clippy --all-targets --workspace -- -D warningscargo test -p paimon-vindex-core --lib: 553 passed, 1 existing ignored test.cargo test -p paimon-vindex-core --test range_search: 52 passed, including the existing Flat and RQ cases.cargo test -p paimon-vindex-core --release --test range_search: 52 passed.cargo test -p paimon-vindex-core --test storage_format_fixtures: 2 passed, 1 existing ignored fixture printer.The exact CI Clippy invocation also supplies
-A clippy::chunks-exact-to-as-chunks, which local Rust 1.95.0 does not recognize. The workspace Clippy command above passes without that lint allowance.Linux/x86_64 and full cross-language CI remain for the repository workflows. There is no storage migration or binding change; reverting this additive PR does not require rewriting index files.
Known review follow-up
Independent review found no blocking issues. One non-blocking P2 hardening follow-up remains: SQ range coarse-probe selection uses the existing unchecked centroid ranking, so a non-finite centroid or an overflowed coarse squared distance in an unselected list can escape validation. This is a source-traced corruption/extreme-value case, not a newly reproduced ordinary-input failure. A follow-up should add SQ-range-only checked probe validation and tests for unselected NaN/overflow cases; existing top-K and RQ behavior remain unchanged here.