[core] Refactor MergeFunctionFactory to use read rowType #7059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zouxxyy
force-pushed
the
dev/adj-merge-func
branch
2 times, most recently
from
1196f43 to
0ad5509
Compare
Zouxxyy
force-pushed
the
dev/adj-merge-func
branch
from
0ad5509 to
98c8277
Compare
Contributor
|
Maybe add a case for this? Why to modify this? |
Contributor
|
Thanks @Zouxxyy , +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A previous TODO item — now variant push must be used, as the new readType with pushed variant struct is required in MergeFunction
Tests
API and Format
Documentation