Repository navigation
Add FileType to the FileMetaData diagram, regenerate - #218
Merged
wgtmac merged 3 commits intoNov 17, 2026
Merged
Conversation
The metadata diagram's LogicalTypes class was missing FileType after parquet-format added the FILE logical type. Update the Mermaid source and regenerate the SVG so the docs page matches the thrift definition.
The FileMetaData diagram was regenerated with mermaid-cli 12 in the previous commit, which changed the default palette. Regenerate the PageHeader diagram the same way so both figures on the Metadata page use the same renderer and look. The diagram source is unchanged.
Contributor
Author
|
@alamb Since you updated the dependency, maybe you want to stamp this one as well? |
Collaborator
|
Thanks for the ping @Baunsgaard COuld you do me a favor and post the changes in this PR: a screen shot of the old diagrams and a screen shot of the new ones? |
Add FiniteVectorType (FINITE_VECTOR logical type, added in apache/parquet-format PR #624) to the LogicalTypes box in FileMetaData.mermaid and regenerate FileMetaData.svg.
Contributor
Author
Sure @alamb here you go, sorry for the delay, I took the liberty to include the new Vector type as well! Some Sceenshots after:
Some Before:
|
alamb
approved these changes
Nov 12, 2026
alamb
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @Baunsgaard -- this looks good to me. The newer rendering is nice with new colors too
wgtmac
approved these changes
Nov 17, 2026
Member
|
Thanks @Baunsgaard and @alamb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






The Metadata page shows a class diagram of
FileMetaData. ItsLogicalTypesbox was missingFileType, which was added to parquet-format in apache/parquet-format#585 (FILElogical type).Change
static/images/FileMetaData.mermaid: addFileTypeto theLogicalTypesclassstatic/images/FileMetaData.svg: regenerate withnpx mmdc -i FileMetaData.mermaid -o FileMetaData.svgstatic/images/PageHeader.svg: regenerate withnpx mmdc -i PageHeader.mermaid -o PageHeader.svg(source unchanged)Both SVGs were regenerated because the mermaid diagrams are now rendered with a newer mermaid version (mermaid-cli 12.x, from #209). The SVGs were previously rendered with 11.x, so their colours and default styling changed. The diagram content is the same, apart from the new
FileTypeentry.Checked against the current submodule thrift (
LogicalTypeunion): every other logical type was already present. OnlyFileTypewas missing. PhysicalTypevalues are unchanged.Verification
FileTypeappears once in the regenerated SVGReviewer checklist
FileTypeunder LogicalTypes after deploy