Skip to content

[improve][test] Improve SubscriptionMessageDispatchThrottlingTest to reduce the execution time#18039

Merged
Technoboy- merged 1 commit intoapache:masterfrom
coderzc:slow/MessageDispatchThrottlingTest
Oct 17, 2022
Merged

[improve][test] Improve SubscriptionMessageDispatchThrottlingTest to reduce the execution time#18039
Technoboy- merged 1 commit intoapache:masterfrom
coderzc:slow/MessageDispatchThrottlingTest

Conversation

@coderzc
Copy link
Copy Markdown
Member

@coderzc coderzc commented Oct 13, 2022

Fixed

Modifications

Only execution once setup/clean and clean tenants/namespaces/ config after the end of each test execution.

Execution time after improve test:

Tests run: 60, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 242.091 s - in org.apache.pulsar.client.api.SubscriptionMessageDispatchThrottlingTest

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: coderzc#14

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 13, 2022
@coderzc coderzc force-pushed the slow/MessageDispatchThrottlingTest branch 2 times, most recently from f7d9d61 to 1f122f1 Compare October 13, 2022 12:32
@Technoboy- Technoboy- added this to the 2.12.0 milestone Oct 14, 2022
@Technoboy- Technoboy- closed this Oct 14, 2022
@Technoboy- Technoboy- reopened this Oct 14, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 14, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.17%. Comparing base (6c65ca0) to head (1c7e5f7).
⚠️ Report is 3523 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18039       +/-   ##
=============================================
+ Coverage     34.91%   46.17%   +11.25%     
- Complexity     5707    17684    +11977     
=============================================
  Files           607     1573      +966     
  Lines         53396   128213    +74817     
  Branches       5712    14100     +8388     
=============================================
+ Hits          18644    59199    +40555     
- Misses        32119    62901    +30782     
- Partials       2633     6113     +3480     
Flag Coverage Δ
unittests 46.17% <ø> (+11.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1120 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderzc coderzc force-pushed the slow/MessageDispatchThrottlingTest branch from 1f122f1 to 1c7e5f7 Compare October 14, 2022 02:45
@coderzc
Copy link
Copy Markdown
Member Author

coderzc commented Oct 14, 2022

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- merged commit 796afff into apache:master Oct 17, 2022
@hangc0276
Copy link
Copy Markdown
Contributor

This PR has two issues

  [INFO] Running org.apache.pulsar.broker.service.persistent.PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest
  Warning:  Tests run: 133, Failures: 0, Errors: 0, Skipped: 133, Time elapsed: 0.074 s - in org.apache.pulsar.broker.service.persistent.PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest
  [INFO] Running org.apache.pulsar.broker.service.persistent.SimpleProducerConsumerTestStreamingDispatcherTest
  Warning:  Tests run: 212, Failures: 0, Errors: 0, Skipped: 212, Time elapsed: 0.117 s - in org.apache.pulsar.broker.service.persistent.SimpleProducerConsumerTestStreamingDispatcherTest

We'd better not merge it before all the CI tests passed. @Technoboy- @codelipenghui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants