Skip to content

[feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools#18218

Merged
Technoboy- merged 16 commits intoapache:masterfrom
tjiuming:dev/offload_trigger_admin
Nov 21, 2022
Merged

[feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools#18218
Technoboy- merged 16 commits intoapache:masterfrom
tjiuming:dev/offload_trigger_admin

Conversation

@tjiuming
Copy link
Copy Markdown
Contributor

@tjiuming tjiuming commented Oct 27, 2022

Motivation

Add offload managedLedgerOffloadThreshold RestAPI and CLI tools

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: tjiuming#8

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 27, 2022
@tjiuming tjiuming changed the title [feat][broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools [broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools Oct 27, 2022
@tjiuming tjiuming changed the title [broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools [admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools Oct 27, 2022
@tjiuming tjiuming changed the title [admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools [feat][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools Oct 27, 2022
@tjiuming tjiuming changed the title [feat][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools [feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools Oct 27, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Oct 28, 2022
@tjiuming tjiuming requested review from Technoboy- and nodece and removed request for Technoboy-, congbobo184, mattisonchao and nodece November 2, 2022 17:23
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 16, 2022

Codecov Report

❌ Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.26%. Comparing base (aeb4503) to head (77b8032).
⚠️ Report is 3301 commits behind head on master.

Files with missing lines Patch % Lines
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 71.42% 5 Missing and 1 partial ⚠️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 80.95% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18218       +/-   ##
=============================================
+ Coverage     31.39%   47.26%   +15.86%     
- Complexity     6651    10465     +3814     
=============================================
  Files           697      697               
  Lines         68015    68058       +43     
  Branches       7285     7286        +1     
=============================================
+ Hits          21353    32166    +10813     
+ Misses        43667    32311    -11356     
- Partials       2995     3581      +586     
Flag Coverage Δ
unittests 47.26% <76.19%> (+15.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pache/pulsar/broker/admin/impl/NamespacesBase.java 64.13% <80.95%> (+51.94%) ⬆️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 59.74% <71.42%> (+50.40%) ⬆️

... and 171 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tjiuming
Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- added type/feature The PR added a new feature or issue requested a new feature area/admin labels Nov 21, 2022
@Technoboy- Technoboy- merged commit 47981c9 into apache:master Nov 21, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin doc-not-needed Your PR changes do not impact docs type/feature The PR added a new feature or issue requested a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants