[fix][broker] Fix return the earliest position when query position by timestamp.#20457
Merged
Jason918 merged 5 commits intoapache:masterfrom Jun 29, 2023
Merged
[fix][broker] Fix return the earliest position when query position by timestamp.#20457Jason918 merged 5 commits intoapache:masterfrom
Jason918 merged 5 commits intoapache:masterfrom
Conversation
tisonkun
reviewed
Jun 15, 2023
Member
There was a problem hiding this comment.
Please add a test case for this kind of behavior change. Also, add a link to your personal fork CI to prove that existing tests are not affected. See https://pulsar.apache.org/contribute/personal-ci/
Barely changing boolean logic is risky.
hanmz
changed the title
wolfstudy
requested review from
315157973,
BewareMyPower,
HQebupt,
Jason918,
aloyszhang,
codelipenghui,
congbobo184,
gaoran10,
hangc0276,
wolfstudy and
zymap
Contributor
|
/pulsarbot rerun-failure-checks |
315157973
reviewed
Jun 27, 2023
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentMessageFinderTest.java
Outdated
Show resolved
Hide resolved
AnonHxy
approved these changes
Jun 27, 2023
Contributor
AnonHxy
left a comment
AnonHxy
left a comment
There was a problem hiding this comment.
LGTM with minor comments
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentMessageFinderTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
aloyszhang
approved these changes
Jun 29, 2023
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Technoboy-
pushed a commit
that referenced
this pull request
Jul 3, 2023
Member
|
You broke the build by checking in an empty file |
Technoboy-
added a commit
that referenced
this pull request
Jul 11, 2023
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 17, 2023
… timestamp. (apache#20457) (cherry picked from commit 0e60340) (cherry picked from commit 6a62499)
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20457 +/- ##
=============================================
+ Coverage 33.58% 73.08% +39.50%
- Complexity 12127 32010 +19883
=============================================
Files 1613 1867 +254
Lines 126241 138758 +12517
Branches 13770 15263 +1493
=============================================
+ Hits 42396 101416 +59020
+ Misses 78331 29298 -49033
- Partials 5514 8044 +2530
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20368
Master Issue: #20368
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: hanmz#1