Skip to content

RATIS-2185. Improve gRPC log messages debugability. #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OneSizeFitsQuorum merged 1 commit into from
Dec 2, 2024
Merged

RATIS-2185. Improve gRPC log messages debugability. #1186

OneSizeFitsQuorum merged 1 commit into from
Dec 2, 2024

Conversation

@szetszwo
Copy link
Contributor

@szetszwo szetszwo commented Nov 29, 2024

RATIS-2185: Improve gRPC log messages debugability. In particular, we fix the followings:

  • Some exceptions in GrpcAdminProtocolService are not printed.
  • The cause exceptions are not printed in GrpcUtil.warn(..).

@szetszwo szetszwo mentioned this pull request Nov 29, 2024
Closed
OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit a4826e2 into apache:master Dec 2, 2024
12 checks passed
@jojochuang
Copy link
Contributor

jojochuang commented Dec 2, 2024

Thanks this is going to be useful

OneSizeFitsQuorum pushed a commit to OneSizeFitsQuorum/ratis that referenced this pull request Dec 15, 2024
@szetszwo @OneSizeFitsQuorum
RATIS-2185. Improve gRPC log messages debugability. (apache#1186)
57b289a
SzyWilliam pushed a commit that referenced this pull request Jan 9, 2025
@szetszwo @SzyWilliam
RATIS-2185. Improve gRPC log messages debugability. (#1186)
486c7e0
SzyWilliam pushed a commit to SzyWilliam/ratis that referenced this pull request Jan 9, 2025
@szetszwo @SzyWilliam
RATIS-2185. Improve gRPC log messages debugability. (apache#1186)
76797b0
szetszwo added a commit that referenced this pull request Jan 9, 2025
@szetszwo
RATIS-2185. Improve gRPC log messages debugability. (#1186)
e49e7f8
szetszwo added a commit to szetszwo/ratis that referenced this pull request May 23, 2025
@szetszwo
RATIS-2185. Improve gRPC log messages debugability. (apache#1186)
6985072
szetszwo added a commit to szetszwo/ratis that referenced this pull request May 23, 2025
@szetszwo
RATIS-2185. Improve gRPC log messages debugability. (apache#1186)
81502aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szetszwo @jojochuang @OneSizeFitsQuorum