RATIS-2228. Refactor the offered map in LogAppenderBase.nextAppendEntriesRequest #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It seems that some unit tests are failing. |
Contributor
Author
|
@jianghuazhu , thanks for reviewing this! Just have fixed the bug. |
Contributor
|
@szetszwo , the refactored code looks great. |
SzyWilliam
approved these changes
Jan 3, 2025
Member
SzyWilliam
left a comment
SzyWilliam
left a comment
There was a problem hiding this comment.
+1 the refractor looks great to me! Consolidating logic to EntryBuffer makes the code really organized!
Contributor
Author
|
@SzyWilliam , thanks a lot for reviewing and merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RATIS-2228
EntryBufferclass for the buffer queue and the ref map.bufferfield fromLogAppenderBase.LogEntryLoaderto not extending guavaCacheLoader.LogEntryLoader.load-- it should re-throw an exception.TermIndexinstead ofLogRecordinLogEntryLoader