RATIS-2233. make NOPROGRESS timeout configurable #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
Jan 2, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@SzyWilliam , thanks a lot for working on this! Just two minor comments inlined.
| setInt(properties::setInt, STAGING_CATCHUP_GAP_KEY, stagingCatchupGap); | ||
| } | ||
|
|
||
| String BOOTSTRAP_TIMEOUT_KEY = PREFIX + ".bootstrap.timeout"; |
Contributor
There was a problem hiding this comment.
Since we already have staging.catchup.gap, how about calling it staging.timeout? It was unfortunate that we already used staging instead of bootstrap.
Member
Author
There was a problem hiding this comment.
No problem, let's use staging.timeout for consistency.
| |:----------------|:------------------------------------| | ||
| | **Description** | timeout of bootstrapping a new peer | | ||
| | **Type** | TimeDuration | | ||
| | **Default** | 3 times of timeoutMax | |
Contributor
There was a problem hiding this comment.
Thanks for updating the doc! Let's use the full name raft.server.rpc.timeout.max.
Member
Author
|
@szetszwo Thanks for reviewing on this! Made changes on code, PTAL. |
szetszwo
approved these changes
Jan 3, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
SzyWilliam
added a commit
that referenced
this pull request
Jan 9, 2025
SzyWilliam
added a commit
to SzyWilliam/ratis
that referenced
this pull request
Jan 9, 2025
szetszwo
pushed a commit
that referenced
this pull request
Jan 9, 2025
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/RATIS-2233