Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  • Bump Apache parent POM to 35
  • Remove Apache Maven plugin version overrides
  • Remove unused plugins
  • Remove duplicate execution of maven-source-plugin, which produced a warning previously:
    [INFO] --- source:3.2.1:jar-no-fork (attach-sources) @ ratis-docs ---
    [INFO] Building jar: /home/runner/work/ratis/ratis/ratis-docs/target/ratis-docs-3.3.0-SNAPSHOT-sources.jar
    ...
    [INFO] --- source:3.2.1:jar-no-fork (ratis-java-sources) @ ratis-docs ---
    [WARNING] artifact org.apache.ratis:ratis-docs:java-source:sources:3.3.0-SNAPSHOT already attached, replace previous instance
    
    but is now an error with the plugin's new version:
    [INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ ratis-docs ---
    [INFO] Building jar: /home/runner/work/ratis/ratis/ratis-docs/target/ratis-docs-3.3.0-SNAPSHOT-sources.jar
    ...
    [INFO] --- source:3.3.1:jar-no-fork (ratis-java-sources) @ ratis-docs ---
    [ERROR] We have duplicated artifacts attached.
    

https://issues.apache.org/jira/browse/RATIS-2354

How was this patch tested?

CI:
https://github.com/adoroszlai/ratis/actions/runs/19260498945

@adoroszlai adoroszlai self-assigned this Nov 11, 2025
@adoroszlai adoroszlai requested a review from szetszwo November 11, 2025 13:11
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit cf6e5d7 into apache:master Nov 11, 2025
15 checks passed
@adoroszlai adoroszlai deleted the RATIS-2354 branch November 11, 2025 18:10
@adoroszlai
Copy link
Contributor Author

Thanks @szetszwo for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants