refactor(security): move security configs to dedicated package#56
Open
adityamparikh wants to merge 5 commits intoapache:mainfrom
Open
refactor(security): move security configs to dedicated package#56adityamparikh wants to merge 5 commits intoapache:mainfrom
adityamparikh wants to merge 5 commits intoapache:mainfrom
Conversation
Rename McpServerConfiguration to HttpSecurityConfiguration and move both HttpSecurityConfiguration and MethodSecurityConfiguration from org.apache.solr.mcp.server.config to org.apache.solr.mcp.server.security. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
- Rename configuration property from `spring.security.enabled` to `http.security.enabled` to avoid collision with Spring Boot's own `spring.security.*` namespace - Rename corresponding environment variable from `SECURITY_ENABLED` to `HTTP_SECURITY_ENABLED` for consistency - Update application-http.properties, HttpSecurityConfiguration, MethodSecurityConfiguration, and keycloak.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Consolidate security-related documentation into a dedicated security-docs directory for better organization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Merges upstream observability additions (OpenTelemetry, tracing config) from apache#41 with security-refactor's property rename (spring.security.enabled → http.security.enabled). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Contributor
|
I've tested with the default path of security NOT enabled, and able to make a connection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpServerConfigurationtoHttpSecurityConfigurationfor clarityconfigto dedicatedorg.apache.solr.mcp.server.securitypackagespring.security.enabledtohttp.security.enabled(env varSECURITY_ENABLED→HTTP_SECURITY_ENABLED)keycloak.mddocumentation to reflect new property namesChanged files
HttpSecurityConfiguration.java— renamed fromMcpServerConfiguration, moved tosecuritypackageMethodSecurityConfiguration.java— moved tosecuritypackage, updated property referenceapplication-http.properties— property renamekeycloak.md— updated property referencesTest plan
./gradlew buildpasses🤖 Generated with Claude Code