refactor(metrics): migrate from /admin/mbeans to /admin/metrics API#61
Open
adityamparikh wants to merge 4 commits intoapache:mainfrom
Open
refactor(metrics): migrate from /admin/mbeans to /admin/metrics API#61adityamparikh wants to merge 4 commits intoapache:mainfrom
adityamparikh wants to merge 4 commits intoapache:mainfrom
Conversation
Replace deprecated /admin/mbeans endpoint with /admin/metrics API (available since Solr 7.1+) for cache and handler metrics collection. This ensures compatibility with both Solr 9 and Solr 10, where /admin/mbeans was removed. Key changes: - Use /admin/metrics?group=core&prefix=CACHE.searcher for cache stats - Use /admin/metrics?group=core&prefix=QUERY./select,UPDATE./update for handler stats - Handle both NamedList and Map response types from Metrics API - Add SLF4J logging to CollectionService - Strengthen integration test assertions for cache and handler stats - Update CLAUDE.md Solr 10 compatibility section Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Restore comprehensive Javadoc comments on all methods and constants in CollectionService, updated to reference the /admin/metrics API instead of the deprecated /admin/mbeans endpoint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
- S1118: Add private constructor to CollectionUtils utility class - S7467: Replace unused caught exceptions with unnamed pattern (_) Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/admin/mbeansendpoint with/admin/metricsAPI (available since Solr 7.1+) for cache and handler metrics collection/admin/mbeanswas removedNamedListandMap(LinkedHashMap) response types from Metrics APIChanges
getCacheMetrics()andgetHandlerMetrics()from/admin/mbeansto/admin/metricswithgroup=coreprefix filtering{metrics: {solr.core.<collection>: {...}}})assertNotNullchecksCollectionServiceTest plan
./gradlew clean buildpasses with no regressions🤖 Generated with Claude Code