refactor: remove standalone Solr support, require SolrCloud#71
Open
adityamparikh wants to merge 1 commit intoapache:mainfrom
Open
refactor: remove standalone Solr support, require SolrCloud#71adityamparikh wants to merge 1 commit intoapache:mainfrom
adityamparikh wants to merge 1 commit intoapache:mainfrom
Conversation
Remove standalone Solr (single-node Core Admin API) support from CollectionService. The project now exclusively supports SolrCloud deployments using the Collections API. Changes: - CollectionService.listCollections() always uses CollectionAdminRequest instead of branching on instanceof CloudSolrClient - Remove unused imports: CloudSolrClient, CoreAdminRequest, CoreAdminResponse, CoreAdminParams - Update Javadoc to reflect SolrCloud-only support - Update SolrConfig comment to remove standalone reference - Simplify unit tests: remove CloudSolrClient-specific and standalone-specific test branches, use unified SolrClient mock Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove standalone Solr (single-node Core Admin API) support from CollectionService. The project now exclusively supports SolrCloud deployments using the Collections API.
CollectionService.listCollections(): Always usesCollectionAdminRequest.List(Collections API) instead of branching oninstanceof CloudSolrClientwith a Core Admin API fallbackCloudSolrClient,CoreAdminRequest,CoreAdminResponse,CoreAdminParamsCollectionServiceandSolrConfigCloudSolrClient-specific and standalone-specific test branches with unifiedSolrClientmock testsThe previous
instanceof CloudSolrClientcheck was effectively dead code — the application always creates anHttp2SolrClient, so the standalone branch (Core Admin API) was always taken, even when connecting to SolrCloud. This change removes the broken dual-mode logic and commits to SolrCloud-only support../gradlew spotlessApply buildpasses cleanly