Skip to content

support integer types in fast_tanh and fast_exp #18768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jikechao wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Open

support integer types in fast_tanh and fast_exp #18768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24ee3ba
supportinteger types in fast_tanh
jikechao Feb 12, 2026
16f8951
Cast integer types to float32 in fast_exp
jikechao Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/tvm/topi/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,8 @@ def fast_exp(x):
y : tvm.te.Tensor
The result.
"""
if x.dtype.startswith('int') or x.dtype.startswith('uint'):
x = cast(x, 'float32')
return cpp.fast_exp(x, x.dtype, tag.ELEMWISE)


Expand All @@ -799,6 +801,8 @@ def fast_tanh(x):
y : tvm.te.Tensor
The result.
"""
if x.dtype.startswith('int') or x.dtype.startswith('uint'):
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This condition can be made more concise. The startswith method can accept a tuple of strings to check for multiple prefixes.

Suggested change
if x.dtype.startswith('int') or x.dtype.startswith('uint'):
if x.dtype.startswith(('int', 'uint')):

x = cast(x, 'float32')
return cpp.fast_tanh(x, x.dtype, tag.ELEMWISE)


Expand Down
Loading