[CI] Update Pillow, pytest-rerunfailures, junitparser, xgboost, onnx and pytorch#18777
Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a continuous integration (CI) issue by modifying the Python package installation script. It removes specific version constraints for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request unpins Pillow, pytest-rerunfailures, and junitparser in the CI environment. While using the latest versions of dependencies can help identify integration issues early, unpinning them completely can lead to non-reproducible builds. This can make it difficult to diagnose CI failures when they are caused by an upstream dependency update. I've added a comment suggesting to instead upgrade these packages to their latest stable versions and keep them pinned. This approach provides the benefits of newer packages while maintaining a deterministic and stable CI environment.
| Pillow \ | ||
| psutil \ | ||
| pytest \ | ||
| git+https://github.com/tlc-pack/tlcpack-sphinx-addon.git@768ec1dce349fe4708f6ad68be1ebb3f3dabafa1 \ | ||
| pytest-profiling \ | ||
| pytest-xdist \ | ||
| pytest-rerunfailures==10.2 \ | ||
| pytest-rerunfailures \ | ||
| requests \ | ||
| scipy \ | ||
| Jinja2 \ | ||
| junitparser==2.4.2 \ | ||
| junitparser \ |
There was a problem hiding this comment.
Unpinning dependencies can lead to non-reproducible builds and make it difficult to debug CI failures caused by upstream changes. To ensure build stability, it's a best practice to pin dependencies to specific versions.
Instead of removing the version pins for Pillow, pytest-rerunfailures, and junitparser, could you please update these packages to their latest stable versions and pin them? This will provide the benefits of newer versions while keeping the CI environment deterministic.
978c152 to
25d1e34
Compare
e10ef93 to
ab0ebe4
Compare
ab0ebe4 to
add8e98
Compare
add8e98 to
051ab62
Compare
Fix #18775 (comment) , update xgboost, onnx and pytorch