Skip to content

Conversation

@manirajv06
Copy link
Contributor

…rchy in going through preemption

What is this PR for?

Quota change preemption should not be allowed through precondition checks if any one of the queue (either upwards or backwards) in the submitted queue hierarchy is already running preemption to enforce its quota change. Preemption would be tried again in next scheduling cycle.

What type of PR is it?

  • - Feature

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-3182

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question.

@manirajv06
Copy link
Contributor Author

Looks good, just one question.

Taken care.

Test would fail as there is dependent change on #1055. Once that has gone in, this should pass.

@manirajv06 manirajv06 requested a review from pbacsko December 12, 2025 10:59
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.84%. Comparing base (04638ef) to head (0dbfd3f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/scheduler/objects/queue.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
- Coverage   81.85%   81.84%   -0.02%     
==========================================
  Files         103      103              
  Lines       13608    13636      +28     
==========================================
+ Hits        11139    11160      +21     
- Misses       2208     2213       +5     
- Partials      261      263       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants