This repository was archived by the owner on Dec 21, 2019. It is now read-only.
Implement secure cookie #34
Open
turnkey-commerce wants to merge 2 commits into
Open
Conversation
|
Changes Unknown when pulling 1b0e405 on turnkey-commerce:secure-cookie into * on apexskier:master*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #33. By default the secure cookie option is set when the NewAuthorizer() is called. To turn it off a special function called AllowInsecureCookie() will need to be called to set it back to false. Error messages are generated if the secure cookie is on and it the site is served over http.
The example is updated so that it will work by default on non-https sites but it has been appropriately commented to not do such in production.
The httpauth version should be incremented since it changes default behavior.