fix(fingerprint-generator): guard generated viewport dimensions#548
Closed
tine1117 wants to merge 1 commit into
Closed
fix(fingerprint-generator): guard generated viewport dimensions#548tine1117 wants to merge 1 commit into
tine1117 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6.
The generated fingerprint network can still return screen records with zero viewport fields such as
innerWidth,innerHeight,clientWidth, andclientHeight. Those values are easy to flag because they do not match a real browser viewport.This change adds a small guard at fingerprint generation time:
client <= inner <= outerviewport invariantsThis complements #544. That PR tightens future training records; this one protects the runtime generator from the current published network output as well.
Validation:
corepack pnpm vitest run test/fingerprint-generator/generation.test.ts --reporter verbosecorepack pnpm exec prettier packages/fingerprint-generator/src/fingerprint-generator.ts test/fingerprint-generator/generation.test.ts --checkgit diff --checknpm exec --yes pnpm@10.33.4 -- buildNote: full
pnpm lintis not clean on the current checkout because repo-wide Prettier reports existing formatting differences in untouched files. The two changed files pass Prettier directly.@algora-pbc /claim #6