Skip to content

fix when use some complex decorator#62

Open
noodle4u wants to merge 1 commit into
apiguy:masterfrom
noodle4u:fix4complex_decorator
Open

fix when use some complex decorator#62
noodle4u wants to merge 1 commit into
apiguy:masterfrom
noodle4u:fix4complex_decorator

Conversation

@noodle4u
Copy link
Copy Markdown

@noodle4u noodle4u commented Aug 6, 2014

when i use some complex decorator.
the get_true_argspec do something wrong with closure
for example

def func_permission(check_func, **deco_kwargs):
def wrapper(fn):
@wraps(fn)
def decorated_view(_args, *_kwargs):
result = check_func(**deco_kwargs)
if result:
return fn(_args, *_kwargs)
return while_no_permission()
return decorated_view
return wrapper

@func_permission(some_check_func)
def get(self, restaurant_id):
restaurant_id = int(restaurant_id)

will raise DecoratorCompatibilityError

this commit will fix this error.
the new get_true_argspec
before raise this exception,will check weather this is the real undecorate function by check the function name.

by the way,which is the best way to post code,bug and the way to re produce this bug?

@noodle4u
Copy link
Copy Markdown
Author

noodle4u commented Aug 6, 2014

sorry 4 that i didn't use markdown to format-.-...

@chrishaines
Copy link
Copy Markdown

+1 I've run into this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants