Repository navigation
Add optional test_requirements input to the PR gate - #8
Merged
Merged
Conversation
Apps whose tests import third-party packages (e.g. requests, responses) can now pass a pip requirements file path; it is installed after the ruff/pytest tooling and before lint/tests, and the gate fails clearly if the file is missing. Empty (the default) skips the step, so existing callers are unaffected. release.yml runs no tests and is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app-ci.ymlinputtest_requirements: path (relative to the repo root) of a pip requirements file. When set, a new step runspip install -r <file>right after the ruff/pytest tooling install and before ruff/pytest; it fails with a::error::if the file is missing.if: ${{ inputs.test_requirements != '' }}, so existing callers get exactly today's behaviour.release.ymlis unchanged (it runs no tests).ci.ymlcaller only).Motivation:
pbujna-apius/splunk-add-on-for-sap-cloudPR #2 fails in Tests withModuleNotFoundError: No module named 'requests'.Test plan
ruff check .,ruff format --check .,pytest -qpass@feat/optional-test-requirements🤖 Generated with Claude Code