Conversation
|
Verdict for the original request: Request changes — the PR contains one library-boundary violation. [HIGH] The Skills Unlocker script overrides a shared library UI owner
botting_tree.UI._draw_main_child = _draw_compact_main_childThis mutates a private method on the shared Required direction:
Why: the current implementation places reusable UI behavior and control of a shared library owner inside one script. That creates an uncontrolled path for other scripts to copy and leaves the library unable to govern its own UI behavior. The bot and route rewrites are not findings by themselves; this review is limited to reusable library behavior, library-owned features, and bypasses of library control. |
This PR consolidates the latest dungeon automation and EOTN tooling improvements into a clean branch based on the current upstream main.
Main changes:
MerchantRules changes are intentionally excluded from this PR.