Expand OutpostRunner routes and improve OutpostFighter recovery - #115
Wellwisher533 wants to merge 2 commits into
Conversation
|
Verdict for the original request: Request changes — PR #115 adds library-owned movement and interaction behavior, but still bypasses library owners and leaves the new coordination path incomplete. [BLOCKER] The reliable-interaction ownership guard is missing at runtime
As a result, movement ownership and auxiliary-action deferral are not enforced by the library. The added tests hide this by injecting a fake coordination module into Required direction:
The current implementation is an optional no-op fallback, not a library-controlled action path. [HIGH] The route helper bypasses the public movement owner
This bypasses the public Required direction:
The current implementation is a script-side bypass of the movement control plane. [HIGH] Reusable interaction ownership is duplicated in the script
That duplicates behavior already owned by Required direction:
The current implementation places reusable library behavior in a script helper instead of integrating it into the owning library layer. [HIGH] The new core module does not satisfy the required type contract The strict Pyright check reports 23 errors in the newly added Required direction:
Scope note: the route data files and private bot orchestration are not findings by themselves. They matter here only where they introduce reusable behavior, bypass a library owner, or expose a library-contract failure. |
Summary
Route fixes included
Verification
git diff --checkpassesRuntime status
Several corrected routes were validated during live gameplay while they were developed. The consolidated latest-upstream PR candidate has offline verification; broad end-to-end in-game validation of every added route is still pending.