Conversation
|
Verdict for the original request: request changes — this PR starts fixing the existing combat-event path, then bypasses it with a second private implementation and silent fallbacks. [BLOCKER]
As a result, the same cast can have different timing information depending on whether HeroAI reads the existing event path, [BLOCKER] The three new As a result, a broken Reforged path does not fail visibly. HeroAI simply uses different timing data, so we cannot know which implementation made an interrupt decision. [BLOCKER] Trying As a result, the PR can appear to support Reforged while bypassing the code that actually needs to be fixed. [P1] Required direction:
The current implementation is a private rewrite with silent fallbacks, not a fix to the existing supported combat-event path. |
Summary
This PR improves the combat-event bridge and interrupt timing without adding any build-specific targeting or team logic.
Changes
Why
Static skill activation times are not always accurate after Fast Casting and other cast-time modifiers. Native cast-time events provide a more reliable interrupt window and reduce late or unnecessary interrupt attempts.
Safety
Testing