Target Ancestors' Rage by adjacent enemy density - #91
Open
Wellwisher533 wants to merge 2 commits into
Open
Wellwisher533 wants to merge 2 commits into
Wellwisher533 wants to merge 2 commits into
Conversation
Owner
|
there is already a routine that handled balled up targets, if your behaviour is more complete and reliable, have it replace the current instead of having a duplicate one |
Contributor
Author
|
Addressed in 38e2095. I generalized the existing Routines.Targeting clustered picker so it can score an explicit candidate set and distinguish an enemy center (excluded from its own nearby-enemy count) from an allied center (all adjacent enemies count). The existing enemy-target defaults and callers are preserved. Ancestors' Rage now only assembles its valid allied/summoned candidates and delegates scoring to that shared routine, removing the duplicate loop. Focused compatibility tests were run locally and remain excluded from the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated strict ally target mode for Ancestors' Rage. It selects a living, targetable allied creature with at least two adjacent living foes, including party allies, the player, spirits and pets, minions, and friendly NPCs or summons. The mode is wired through regular HeroAI, BuildMgr/headless, and legacy SkillManager without changing AllyMartial behavior for other skills. Verification: all seven changed Python files compile; eight focused local targeting and wiring tests passed; Ancestors' Rage targeting was confirmed working in-game. Local test scripts are intentionally excluded from this PR.