Skip to content

switch over to npm staged publishing#557

Merged
phryneas merged 2 commits into
mainfrom
pr/staged-publishing
Jun 18, 2026
Merged

switch over to npm staged publishing#557
phryneas merged 2 commits into
mainfrom
pr/staged-publishing

Conversation

@phryneas

@phryneas phryneas commented Jun 12, 2026

Copy link
Copy Markdown
Member

I've already changed the permissions on npm side:

{
  "type": "github",
  "file": "publish.yml",
  "repository": "apollographql/apollo-client-integrations",
  "permissions": [
    "createStagedPackage"
  ],
  "package": "@apollo/client-integration-tanstack-start"
}
{
  "type": "github",
  "file": "publish.yml",
  "repository": "apollographql/apollo-client-integrations",
  "permissions": [
    "createStagedPackage"
  ],
  "package": "@apollo/client-integration-react-router"
}
{
  "type": "github",
  "file": "publish.yml",
  "repository": "apollographql/apollo-client-integrations",
  "permissions": [
    "createStagedPackage"
  ],
  "package": "@apollo/client-integration-nextjs"
}
{
  "type": "github",
  "file": "publish.yml",
  "repository": "apollographql/apollo-client-integrations",
  "permissions": [
    "createStagedPackage"
  ],
  "package": "@apollo/client-react-streaming"
}
{
  "type": "github",
  "file": "publish.yml",
  "repository": "apollographql/apollo-client-integrations",
  "permissions": [
    "createStagedPackage"
  ],
  "package": "@apollo/experimental-nextjs-app-support"
}

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions Node.js setup to require version 26.3.0 or higher.
    • Added a publishing wrapper to translate npm publish into staged publishing, ensuring releases use the staged publish flow before proceeding with the existing release process.

@phryneas phryneas requested a review from jerelmiller June 12, 2026 14:36
@phryneas phryneas requested a review from a team as a code owner June 12, 2026 14:36
@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 67efc13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apollo__client-integration-react-router Ready Ready Preview, Comment Jun 17, 2026 12:59pm
apollo__client-integration-tanstack-start Ready Ready Preview, Comment Jun 17, 2026 12:59pm
apollo__experimental-nextjs-app-support Building Building Preview, Comment Jun 17, 2026 12:59pm

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for apollo-client-nextjs-docmodel ready!

Name Link
🔨 Latest commit 67efc13
🔍 Latest deploy log https://app.netlify.com/projects/apollo-client-nextjs-docmodel/deploys/6a329788e234be0008e10ed1
😎 Deploy Preview https://deploy-preview-557--apollo-client-nextjs-docmodel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@phryneas phryneas changed the title switch over to staged publishing switch over to npm staged publishing Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ecee9fe2-525a-416f-bba1-207b68a587cf

📥 Commits

Reviewing files that changed from the base of the PR and between 8aae069 and 67efc13.

📒 Files selected for processing (1)
  • scripts/changesets-wrapper/npm
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/changesets-wrapper/npm
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: size
  • GitHub Check: pkg-pr-new Publish
  • GitHub Check: Redirect rules - apollo-client-nextjs-docmodel
  • GitHub Check: Header rules - apollo-client-nextjs-docmodel
  • GitHub Check: Pages changed - apollo-client-nextjs-docmodel
  • GitHub Check: pkg-pr-new Publish
  • GitHub Check: Ubuntu/Node v20

📝 Walkthrough

Walkthrough

This PR adds a staged publishing shim to the release workflow. A new bash wrapper script intercepts npm publish calls and rewrites them to npm stage publish. The publish workflow is updated to prepend this wrapper to PATH before running changesets, and Node.js is upgraded from 24.x to >=26.3.0.

Changes

Staged Publishing via npm Shim

Layer / File(s) Summary
npm publish shim and workflow integration
scripts/changesets-wrapper/npm, .github/workflows/publish.yml
New bash wrapper intercepts npm publish and rewrites it to npm stage publish, forwarding all other npm commands unchanged. Workflow step appends wrapper directory to $GITHUB_PATH before changesets action, and Node.js runtime requirement is bumped to >=26.3.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • jerelmiller
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'switch over to npm staged publishing' accurately and concisely summarizes the primary change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pr/staged-publishing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Jun 12, 2026

Copy link
Copy Markdown
@apollo/client-react-streaming

npm i https://pkg.pr.new/apollographql/apollo-client-integrations/@apollo/client-react-streaming@557

@apollo/experimental-nextjs-app-support

npm i https://pkg.pr.new/apollographql/apollo-client-integrations/@apollo/experimental-nextjs-app-support@557

@apollo/client-integration-nextjs

npm i https://pkg.pr.new/apollographql/apollo-client-integrations/@apollo/client-integration-nextjs@557

@apollo/client-integration-react-router

npm i https://pkg.pr.new/apollographql/apollo-client-integrations/@apollo/client-integration-react-router@557

@apollo/client-integration-tanstack-start

npm i https://pkg.pr.new/apollographql/apollo-client-integrations/@apollo/client-integration-tanstack-start@557

commit: 67efc13

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
{ ApolloNextAppProvider, ApolloClient, InMemoryCache } from '@apollo/client-integration-nextjs' (Browser ESM) 10.18 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 2.18 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 9.09 KB (0%)
@apollo/client-react-streaming (Browser ESM) 8.62 KB (0%)
@apollo/client-react-streaming (SSR ESM) 8.95 KB (0%)
@apollo/client-react-streaming (RSC ESM) 9.28 KB (0%)
@apollo/client-react-streaming/manual-transport (Browser ESM) 9.3 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 9.95 KB (0%)
@apollo/client-integration-nextjs (Browser ESM) 10.73 KB (0%)
@apollo/client-integration-nextjs (SSR ESM) 15.8 KB (0%)
@apollo/client-integration-nextjs (RSC ESM) 9.17 KB (0%)

@phryneas phryneas merged commit 3a5653c into main Jun 18, 2026
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants