Skip to content

chore: verify & commentate socket2 requirement - #8955

Merged
goto-bus-stop merged 1 commit into
bryn/otel-0.31-migrationfrom
renee/otel-0.31-socket2
Mar 4, 2026
Merged

chore: verify & commentate socket2 requirement#8955
goto-bus-stop merged 1 commit into
bryn/otel-0.31-migrationfrom
renee/otel-0.31-socket2

Conversation

@goto-bus-stop

@goto-bus-stop goto-bus-stop commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Opened a fred.rs PR to fix upstream; meanwhile we'll keep the explicit socket2 dependency.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

No tests for comment-only change

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@apollo-librarian

apollo-librarian Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 9 changed, 1 removed
* graphos/routing/(latest)/self-hosted/index.mdx
* graphos/routing/(latest)/self-hosted/containerization/aws.mdx
* graphos/routing/(latest)/self-hosted/containerization/azure.mdx
* graphos/routing/(latest)/self-hosted/containerization/docker-router-only.mdx
* graphos/routing/(latest)/self-hosted/containerization/docker.mdx
* graphos/routing/(latest)/self-hosted/containerization/gcp.mdx
* graphos/routing/(latest)/self-hosted/containerization/index.mdx
* graphos/routing/(latest)/self-hosted/containerization/kubernetes/quickstart.mdx
* graphos/routing/(latest)/_sidebar.yaml
- graphos/routing/(latest)/self-hosted/containerization/proxy-certificates.mdx

Build ID: 6b70aa54856e4377b87084b9
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/6b70aa54856e4377b87084b9


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@goto-bus-stop
goto-bus-stop force-pushed the renee/otel-0.31-socket2 branch from 9c9760a to d22261d Compare March 4, 2026 10:19
@goto-bus-stop goto-bus-stop reopened this Mar 4, 2026
@goto-bus-stop
goto-bus-stop marked this pull request as ready for review March 4, 2026 10:27
@goto-bus-stop
goto-bus-stop requested a review from a team as a code owner March 4, 2026 10:27
@goto-bus-stop
goto-bus-stop merged commit b93d03e into bryn/otel-0.31-migration Mar 4, 2026
14 checks passed
@goto-bus-stop
goto-bus-stop deleted the renee/otel-0.31-socket2 branch March 4, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants