Open master merge by anuragsarkar97 · Pull Request #8 · apolloio/chewy

anuragsarkar97 · 2023-08-16T07:36:38Z

No description provided.

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.63.4...v1.63.5) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update rubocop requirement from 1.63.5 to 1.64.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.63.5...v1.64.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Fix rubocop --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Samuel Ebeagu <samuel.ebeagu@toptal.com>

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.64.1...v1.65.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.65.0...v1.65.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ES 8.x upgrade * Fix termnite after changes * fixup es * Elastic security on: configuration example * Mass index deletion disabled by default in Elastic * Elastic docker file: increase sleep, bump image * Spec fixes * bump dependency * Bump version, update docs --------- Co-authored-by: Danil Nurgaliev <danil.nurgaliev@toptal.com>

* Fix id conversion issue in delayed_sidekiq strategy Ensure ids extracted from Redis remain strings, preventing UUID issues. Previously, ids were being converted to integers, causing problems with UUIDs in the `delayed_sidekiq` strategy. This update also enhances the test suite: - Existing tests are updated. - A new test ensures the issue is resolved. Due to SQLite's lack of UUID support, a `stub_uuid_model` method is added. This method stubs models with UUIDs, using `SecureRandom.uuid` for the primary key. Move table creations to individual methods. Having every table creation inside a single block casued Rubocop `Metrics/BlockLength` error. To fix it I moved each table creation to an individual method. * Add changelog notes --------- Co-authored-by: Sundus Yousuf <sundus.yousuf@recruitmilitray.com>

orca-security-us

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Infrastructure as Code	0 0 0 0	View in Orca
Passed	Secrets	0 0 0 0	View in Orca
Passed	Vulnerabilities	0 0 0 0	View in Orca

kodem-security · 2025-11-21T06:53:26Z

Kodem Security Scan Summary

Status	Check	Issues by Severity	Link
✅ Passed	Open Source Security Report		Link to Check

kodem-security · 2025-11-21T06:53:56Z

Kodem Security Scan Summary

Status	Check	Issues by Severity	Link
✅ Passed	Code Weakness Security Report	🟧 M: 1	Link to Check

Note: Kai marked all findings as likely false positives.

Rails 6.1 and 7.0 have reached EOL, and 7.1 is approaching it. Requiring Rails >= 7.2 and Ruby >= 3.2 aligns with currently supported versions and fixes CI incompatibilities with older combinations.

The pinned 1.65.1 was incompatible with newer rubocop-ast, breaking CI. Bump to latest, target Ruby 3.2, and regenerate the todo file.

sqlite3 ~> 1.4 conflicts with Rails 8.0 (requires >= 2.1). Unpinned unparser pulls versions incompatible with Ruby 3.4 AST.

Bump actions/checkout to v6, run rubocop on Ruby 3.4, add workflow_dispatch for manual CI triggers, and remove the deprecated docker-compose version key.

ActiveRecord returns frozen arrays from pluck/import_fields in newer versions. Use map to build new arrays instead of mutating in place.

Ruby 3.4 changed Hash#inspect to use the new syntax ({key: value} instead of {:key=>value}). Relax the assertions to match substrings or patterns instead of exact inspect output.

- "related to other" -> "related to each other" - "elastisearch" -> "Elasticsearch" - "ElasticSearch" -> "Elasticsearch" (7 occurrences) - "city4..do_update!" -> "city4.do_update!" - "except except" -> "except" - Fix sentence fragment in Minitest integration section - Add missing period - "Describe the brief of the change" -> "Describe the change briefly" - "all the the" -> "all the"

The README was ~1370 lines mixing tutorial, reference, and configuration docs. Split the detailed content into focused files under docs/ while keeping the README as a concise entry point with links.

- Replace `its/should` with `specify/expect` in config_spec and repository_spec (also removes a duplicate transport_logger test) - Remove duplicate specify blocks in query_proxy_spec - Remove permanently-pending Groovy script tests in response_spec (Groovy scripting unsupported since ES 6) - Modernize version test description in chewy_spec - Remove broken xdescribe '.massacre' (never called .massacre, incorrect setup, untestable with ES 8 defaults) - Remove xcontext 'applying journal' from actions_spec (timing- dependent, full of debug prints, covered by journaling context)

The gem is no longer used anywhere in the test suite after the earlier test modernization pass.

Chewy works fine without Rails but the docs assume it everywhere. Add a standalone guide for non-Rails setup and a FAQ answering recurring user questions (UndefinedUpdateStrategy, versioning policy, OpenSearch support, Elastic Cloud connection).

A modernized, self-contained tutorial using a media library domain (books + authors). Covers index definition, model callbacks, import, strategies, a search form object pattern, controller integration, sorting, error handling and testing.

- querying.md: add sorting section and error handling for bad user queries - indexing.md: add keyword sub-field example for sorting on text fields - testing.md: add end-to-end search testing example (purge/import/query)

…#994)

Cover Strategy::Base, error classes, Index::Crutch, Search::Scoping, Adapter::Base, IndicesBoost, AllowPartialSearchResults, DelayedSidekiq::Scheduler, and DelayedSidekiq::Worker.

* Allow ruby version 4.0 in gemspec * Add ruby 4.0 to CI matrix

Both services are no longer in use for this project.

dependabot bot and others added 11 commits May 23, 2024 14:52

Rename team (#957)

2d6a3f5

Bump chewy version to 8.0.0-beta (#963)

d2c38f7

Assign dependabot PR's to sre (#966)

5193d28

Adding Ruby 3.3 and Rails 7.2 to CI matrix (#967)

17597e6

updating ruby and active record versions based on test suite (#968)

21c5407

akshay-apollo force-pushed the master branch from f2dace4 to 2b97a59 Compare November 22, 2024 19:45

tylerwillingham added 3 commits November 21, 2025 08:52

Add Ruby 3.4 to CI matrix

7b09b20

Add Rails 8.0 to CI matrix

8d8c778

Remove EOL Ruby versions 3.0 and 3.1 from CI matrix

6b202d5

orca-security-us bot reviewed Nov 21, 2025

View reviewed changes

bbatsov added 12 commits November 21, 2025 08:58

Update codeowners

18132fe

[Fix #980] Remove mention of journal_name from the docs

c4624f0

Tweak some wording

767c850

Bump the copyright years

e55bfc1

Bump the copyright years

fde2fdc

Drop support for Rails <= 7.1

be79f8f

Rails 6.1 and 7.0 have reached EOL, and 7.1 is approaching it. Requiring Rails >= 7.2 and Ruby >= 3.2 aligns with currently supported versions and fixes CI incompatibilities with older combinations.

Update RuboCop to 1.84.2 and regenerate todo

23b5721

The pinned 1.65.1 was incompatible with newer rubocop-ast, breaking CI. Bump to latest, target Ruby 3.2, and regenerate the todo file.

Update sqlite3 to ~> 2.1 and pin unparser to ~> 0.6.15

eb591ec

sqlite3 ~> 1.4 conflicts with Rails 8.0 (requires >= 2.1). Unpinned unparser pulls versions incompatible with Ruby 3.4 AST.

Modernize GitHub Actions and docker-compose setup

b25cfc0

Bump actions/checkout to v6, run rubocop on Ruby 3.4, add workflow_dispatch for manual CI triggers, and remove the deprecated docker-compose version key.

Fix FrozenError in Syncer when mutating frozen arrays

cd5fd71

ActiveRecord returns frozen arrays from pluck/import_fields in newer versions. Use map to build new arrays instead of mutating in place.

Fix specs broken by Ruby 3.4 Hash#inspect format change

ca10cc7

Ruby 3.4 changed Hash#inspect to use the new syntax ({key: value} instead of {:key=>value}). Relax the assertions to match substrings or patterns instead of exact inspect output.

Update README compatibility to reflect current Ruby/Rails support

010e129

bbatsov and others added 19 commits February 25, 2026 15:15

Add note about Ruby/Rails version support policy

f7b606d

Split README into focused documentation files

2d07d48

The README was ~1370 lines mixing tutorial, reference, and configuration docs. Split the detailed content into focused files under docs/ while keeping the README as a concise entry point with links.

Improve documentation: cross-links, troubleshooting, docs index

f74a271

Release Chewy 8.0.0

4c8d17f

Update gemspec files

2d0b089

Add CHANGELOG.md entry

a7719e0

Capture output in rake helper spec

259089f

Drop rspec-its dependency

7049f57

The gem is no longer used anywhere in the test suite after the earlier test modernization pass.

Add getting-started tutorial

ced6168

A modernized, self-contained tutorial using a media library domain (books + authors). Covers index definition, model callbacks, import, strategies, a search form object pattern, controller integration, sorting, error handling and testing.

Improve querying, indexing and testing docs

2c99c51

- querying.md: add sorting section and error handling for bad user queries - indexing.md: add keyword sub-field example for sorting on text fields - testing.md: add end-to-end search testing example (purge/import/query)

Add rails 8.1 to CI matrix

40f3a58

Replace parser gem with prism for Witchcraft AST parsing on Ruby 3.3+ (…

884b1f3

…#994)

Add missing specs for untested source files

677b694

Cover Strategy::Base, error classes, Index::Crutch, Search::Scoping, Adapter::Base, IndicesBoost, AllowPartialSearchResults, DelayedSidekiq::Scheduler, and DelayedSidekiq::Worker.

Allow ruby version 4.0 (#1003)

f6e3bff

* Allow ruby version 4.0 in gemspec * Add ruby 4.0 to CI matrix

Release Chewy 8.0.1 (#1005)

8aef6af

Remove dead Code Climate and Inch CI badges

6f4beeb

Both services are no longer in use for this project.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Open master merge#8

Open master merge#8
anuragsarkar97 wants to merge 45 commits intoapolloio:masterfrom
toptal:master

anuragsarkar97 commented Aug 16, 2023

Uh oh!

orca-security-us bot left a comment •

edited

Loading

Uh oh!

kodem-security bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

kodem-security bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

anuragsarkar97 commented Aug 16, 2023

Uh oh!

orca-security-us bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Orca Security Scan Summary

Uh oh!

kodem-security bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kodem Security Scan Summary

Uh oh!

kodem-security bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kodem Security Scan Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

orca-security-us bot left a comment •

edited

Loading

kodem-security bot commented Nov 21, 2025 •

edited

Loading

kodem-security bot commented Nov 21, 2025 •

edited

Loading