(update) Add EF3.1 methods to impact methods Enums.#42
Merged
Conversation
… ReCiPe ones. Update unique score weighting and normalization datafiles accordingly. Update tests accordingly.
mabrnt
reviewed
Jan 21, 2026
Collaborator
There was a problem hiding this comment.
May be change function description without ReCiPe and with EF v 3.1 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add EF3.1 methods to impact methods Enums.
Remove deprecated ReCiPe ones.
Update unique score weighting and normalization datafiles accordingly.
Update tests accordingly: cover EF3.1 unique score computation, add a new test to check consistency between full name and short name Enums, rename
test_unique_score.pytest file to more generictest_impact_method.py.