fix: repair stale CMake state with doctor - #442
Merged
Conversation
janicduplessis
marked this pull request as ready for review
September 5, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Android CMake configurations created before ccache was enabled can retain an empty launcher. Doctor flags this but currently offers only manual deletion instructions, and healthy app configurations can hide stale ones in native dependencies.
Solution
stim doctor --fix --platform androidclears affected generated configurations and reports the remaining findings. Plain doctor scans the app and installed native modules, including mixed healthy/stale state; Android builds gain no extra checks. Shared sandbox repair still applies on Android, and an unrestricted Codex session does not report a false repair failure.Cleanup requires ignored, untracked output within the checkout and preserves custom launcher settings. Stop all native builds and keep them stopped until repair finishes: the supplemental cache-lock check cannot detect uncached builds, release-swap fallback builds, or direct Gradle. Removed output is recreated on the next build, while shared ccache entries remain intact.
Test plan
Verified with real Git and CMake: configured and built without a launcher, repaired with doctor, then reconfigured and observed ccache in the actual C++ compile command. Regression coverage checks post-repair JSON under Claude and Codex, shared sandbox allowances, idempotence, healthy configurations, tracked/unignored output, linked dependencies, custom launchers, and detected build locks.
Fixes #440