fix: validate benchmark caches with the pinned fingerprint library - #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SDK 58 benchmark refused a successfully built golden because it calculated the expected cache key with the app's fingerprint dependency. rc.17 uses a different version; the two versions enumerate different inputs and produce different hashes for the same app.
Solution
Resolve the fingerprint implementation from the pinned Stim package while hashing the fixture directory. Keep the platform and generated-path exclusions unchanged. This changes only benchmark validation, not published Stim behavior or stored cache keys.
Test plan
The regression supplies a conflicting fixture fingerprint package and exercises the real pinned implementation: machine-local Android configuration and iOS edits preserve the Android key, while an Android native edit invalidates it. On the SDK 58 fixture, the pinned implementation reproduces the stored
47b4b4cache key instead of the fixture dependency's7999f7key.Fixes #451.