Skip to content

ADFA-3119 | Fix crash when generating setters and getters #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jatezzz merged 2 commits into from
Mar 5, 2026
Merged

ADFA-3119 | Fix crash when generating setters and getters #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f438cf
fix: prevent StringIndexOutOfBoundsException in setter/getter generator
jatezzz Mar 4, 2026
81bf22b
refactor: refine error handling for setter/getter generator
jatezzz Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions ...java/com/itsaky/androidide/lsp/java/actions/generators/GenerateSettersAndGettersAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,14 @@ class GenerateSettersAndGettersAction : FieldBasedAction() {
private val log = LoggerFactory.getLogger(GenerateSettersAndGettersAction::class.java)
}

private fun showErrorMessage(error: Throwable, context: Context?) {
log.error("Unable to generate setters and getters", error)
context ?: return
ThreadUtils.runOnUiThread {
flashError(context.getString(R.string.msg_cannot_generate_setters_getters))
}
}

override fun onGetFields(fields: List<String>, data: ActionData) {

showFieldSelector(fields = fields, data = data, actionId = id, listener = { checkedNames ->
Expand All @@ -76,12 +84,7 @@ class GenerateSettersAndGettersAction : FieldBasedAction() {
_, error,
->
if (error != null) {
log.error("Unable to generate setters and getters", error)
ThreadUtils.runOnUiThread {
flashError(
data[Context::class.java]!!.getString(R.string.msg_cannot_generate_setters_getters)
)
}
showErrorMessage(error, data[Context::class.java])
return@whenComplete
}
}
Expand Down Expand Up @@ -132,8 +135,12 @@ class GenerateSettersAndGettersAction : FieldBasedAction() {
}

ThreadUtils.runOnUiThread {
editor.text.insert(insert.line, insert.column, sb)
editor.formatCodeAsync()
try {
editor.text.insert(insert.line, insert.column, sb)
editor.formatCodeAsync()
} catch (e: StringIndexOutOfBoundsException) {
showErrorMessage(e, data[Context::class.java])
}
}
}

Expand Down
11 changes: 10 additions & 1 deletion lsp/java/src/main/java/com/itsaky/androidide/lsp/java/utils/EditHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,19 @@ public static Position insertAtEndOfClass(JavacTask task, CompilationUnitTree ro
) {
SourcePositions pos = Trees.instance(task).getSourcePositions();
LineMap lines = root.getLineMap();

long end = pos.getEndPosition(root, leaf);

if (end < 0) throw new IllegalStateException("Cannot determine class end position");

int line = (int) lines.getLineNumber(end);
int column = (int) lines.getColumnNumber(end);
return new Position(line - 1, column - 2);

if (line <= 0 || column <= 0) {
throw new IllegalStateException("Invalid class end position: line=" + line + ", column=" + column);
}

return new Position(line - 1, Math.max(0, column - 2));
}

private static String printParameters(final ExecutableType method, final MethodTree source) {
Expand Down