Skip to content

ADFA-4317: Indicate scrolling on code characters toolbar#1387

Merged
dara-abijo-adfa merged 5 commits into
stagefrom
ADFA-4317-indicate-scrolling-on-code-characters
Jun 18, 2026
Merged

ADFA-4317: Indicate scrolling on code characters toolbar#1387
dara-abijo-adfa merged 5 commits into
stagefrom
ADFA-4317-indicate-scrolling-on-code-characters

Conversation

@dara-abijo-adfa

Copy link
Copy Markdown
Contributor

Indicate that the code characters toolbar is scrollable by displaying a horizontal scrollbar.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 98a4200f-e75b-4be7-9c6d-95f7956ade21

📥 Commits

Reviewing files that changed from the base of the PR and between 4d9b100 and 07406b6.

📒 Files selected for processing (1)
  • app/src/main/res/layout/layout_editor_bottom_sheet.xml

📝 Walkthrough

Release Notes

Features

  • Added horizontal scrollbar to the code characters toolbar to make its scrollable nature more apparent to users
    • Scrollbar is always visible with the horizontal track drawn
    • Configured with 2dp height and outsideInset style positioning

User-Facing Changes

  • The code characters toolbar now displays a persistent horizontal scroll indicator, improving discoverability of the scrollable content

Risks & Best Practices Considerations

  • Hardcoded scrollbar dimensions: The 2dp scrollbar size is fixed and may not scale appropriately for different screen densities or accessibility requirements (e.g., users with motor impairments may need larger touch targets)
  • Opinionated styling: The always-visible horizontal track and outsideInset positioning may impact visual spacing and layout consistency; verify alignment with design system standards across different Android versions

Walkthrough

Five XML attributes are added to the SymbolInputView element in layout_editor_bottom_sheet.xml to configure horizontal scrollbar display: fade disabled, horizontal track forced, size set to 2dp, style set to outsideInset, and horizontal scrollbars enabled.

Changes

SymbolInputView Horizontal Scrollbar Styling

Layer / File(s) Summary
SymbolInputView scrollbar attributes
app/src/main/res/layout/layout_editor_bottom_sheet.xml
Adds fadeScrollbars="false", requiresFadingEdge="horizontal", scrollbarSize="2dp", scrollbarStyle="outsideInset", and scrollbars="horizontal" to the SymbolInputView element.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny scrollbar, slim and neat,
Two dips tall from head to feet,
No fading tricks, no inset hide —
It glides outside with bunny pride! 🐇
The symbols scroll, the track stays true,
A crisp little line in the editor view.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a horizontal scrollbar indicator to the code characters toolbar to show it's scrollable.
Description check ✅ Passed The description is directly related to the changeset, explaining that a horizontal scrollbar is being added to the code characters toolbar to indicate scrollability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-4317-indicate-scrolling-on-code-characters

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dara-abijo-adfa dara-abijo-adfa merged commit 3ff1495 into stage Jun 18, 2026
2 checks passed
@dara-abijo-adfa dara-abijo-adfa deleted the ADFA-4317-indicate-scrolling-on-code-characters branch June 18, 2026 21:52
jatezzz pushed a commit that referenced this pull request Jun 22, 2026
* feat(ADFA-4317): Show scrollbar in code character toolbar

* feat(ADFA-4317): Adjust scrollbar size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants