Skip to content

ADFA-4320 Paper cut: Fix for swiping bottom sheet tabs incorrectly opening file menu #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hal-eisen-adfa wants to merge 3 commits into
base: stage
Choose a base branch
from
Open

ADFA-4320 Paper cut: Fix for swiping bottom sheet tabs incorrectly opening file menu #1390

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da1e435
Fix for swiping bottom sheet tabs incorrectly opening file menu
hal-eisen-adfa Jun 15, 2026
665c4b9
ADFA-4320 Skip drawer fling-open when swiping bottom sheet tabs
hal-eisen-adfa Jun 15, 2026
53f843f
ADFA-4320 Move tab-strip check into onFling and harden against teardown
hal-eisen-adfa Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion app/src/main/java/com/itsaky/androidide/activities/editor/BaseEditorActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import android.content.Intent
import android.content.ServiceConnection
import android.content.res.Configuration
import android.graphics.Color
import android.graphics.Rect
import android.graphics.drawable.GradientDrawable
import android.os.Build
import android.os.Bundle
Expand Down Expand Up @@ -1601,7 +1602,9 @@ abstract class BaseEditorActivity :
}

// Filter out diagonal flings so only an intentional right swipe opens the drawer.
if (isDrawerOpenFling) {
// A horizontal fling that started on the bottom-sheet tab strip is the user
// scrolling tabs, not asking for the drawer.
if (isDrawerOpenFling && !isTouchOnBottomSheetTabs(e1)) {
binding.editorDrawerLayout.openDrawer(GravityCompat.START)
return true
}
Expand All @@ -1621,6 +1624,13 @@ abstract class BaseEditorActivity :
return super.dispatchTouchEvent(ev)
}

private fun isTouchOnBottomSheetTabs(ev: MotionEvent): Boolean {
val tabs = contentOrNull?.bottomSheet?.binding?.tabs ?: return false
val rect = Rect()
if (!tabs.getGlobalVisibleRect(rect)) return false
return rect.contains(ev.rawX.toInt(), ev.rawY.toInt())
}

private fun showTooltip(tag: String) {
TooltipManager.showIdeCategoryTooltip(
context = this,
Expand Down
Loading