Skip to content

feat(ADFA-4321): Paper cut: Add a clear icon to the app name text field#1392

Merged
dara-abijo-adfa merged 2 commits into
stagefrom
ADFA-4321-papercut-clear-default-app-name-instantly-old
Jun 18, 2026
Merged

feat(ADFA-4321): Paper cut: Add a clear icon to the app name text field#1392
dara-abijo-adfa merged 2 commits into
stagefrom
ADFA-4321-papercut-clear-default-app-name-instantly-old

Conversation

@dara-abijo-adfa

@dara-abijo-adfa dara-abijo-adfa commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Add a one-click option to clear the default project name when creating a new project

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

A new showClearIcon boolean property is added to TextFieldParameter, TextFieldParameterBuilder, StringParameter, and StringParameterBuilder. The view provider's configureTextFieldCommon conditionally sets TextInputLayout.END_ICON_CLEAR_TEXT when the flag is true. projectNameParameter enables this flag.

Changes

Clear Icon for Text Field Parameters

Layer / File(s) Summary
TextFieldParameter API and builder wiring
templates-api/.../parameters.kt
Adds showClearIcon: Boolean = false to TextFieldParameter constructor (with updated KDoc), TextFieldParameterBuilder, StringParameter constructor and forwarding call to super, StringParameterBuilder build call, and sets showClearIcon = true in projectNameParameter.
TextInputLayout clear icon rendering
templates-impl/.../TemplateWidgetViewProviderImpl.kt
configureTextFieldCommon checks showClearIcon and assigns root.endIconMode = TextInputLayout.END_ICON_CLEAR_TEXT when enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 Hop, hop, a little X appears,
To clear the text and calm your fears,
A boolean flag, so small, so neat,
Makes project name fields feel complete.
The builder wires, the view obeys—
Clean fields for coding sunny days! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding a clear icon to enable one-click clearing of the default project name.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: adding a clear icon to the app name text field, which is the primary feature across both modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-4321-papercut-clear-default-app-name-instantly-old

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hal-eisen-adfa hal-eisen-adfa changed the title feat(ADFA-4321): Add a clear icon to the app name text field feat(ADFA-4321): Paper cut: Add a clear icon to the app name text field Jun 15, 2026
@dara-abijo-adfa dara-abijo-adfa merged commit d73ec0b into stage Jun 18, 2026
2 checks passed
@dara-abijo-adfa dara-abijo-adfa deleted the ADFA-4321-papercut-clear-default-app-name-instantly-old branch June 18, 2026 22:36
jatezzz pushed a commit that referenced this pull request Jun 22, 2026
…ld (#1392)

feat(ADFA-4321): Add a clear icon to the app name text field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants