ADFA-3364: Skip corrupt JARs during classpath indexing (+ surface to user)

[fryanpan]

Jira Ticket: https://appdevforall.atlassian.net/browse/ADFA-3364
Sentry Issue: https://appdevforall-inc-9p.sentry.io/issues/APPDEVFORALL-Y8

Reproduction Details

JarFsClasspathReader.listClasses opened each classpath entry as a JAR filesystem and walked it with no error handling. A single truncated/zero-byte/corrupt .jar (e.g. an interrupted download / incomplete offline provisioning) throws java.util.zip.ZipException, which propagated out and aborted indexing of every remaining (valid) classpath entry.

Stack Trace

ZipException: zip END header not found
  at com.itsaky.androidide.zipfs2.ZipFileSystem.zerror(...)
  at com.itsaky.androidide.zipfs2.ZipFileSystem.findEND(...)
  at com.itsaky.androidide.zipfs2.ZipFileSystem.<init>(...)
  at com.itsaky.androidide.javac.services.fs.CachingJarFileSystemProvider.newFileSystem(...)
  at com.itsaky.androidide.projects.classpath.JarFsClasspathReader.listClasses(Unknown Source:77)
  at com.itsaky.androidide.projects.api.ModuleProject.indexClasspaths(...)
  at com.itsaky.androidide.projects.ProjectManagerImpl$setup$6$jobs$1$1.invokeSuspend(...)

(device: vivo Y22s · device.class: medium · Android 14)

User Steps

User steps leading up to crash, based on Sentry breadcrumbs:

• User opens a project; on setup the per-module classpath indexing job runs (ModuleProject.indexClasspaths) and walks each dependency jar.
• One classpath jar is corrupt/truncated → ZipException aborts the whole indexing pass.

Was able to reproduce in a unit test?

Yes.
JarFsClasspathReaderCorruptJarTest (:subprojects:projects) feeds [corrupt.jar (64-byte truncated), empty.jar (0 bytes), valid android.jar] and asserts android.content.Context is still indexed (>100 classes). Baseline: FAILS with ZipException; branch: passes. A second test asserts the skipped jars are collected (unreadableJars = corrupt.jar + empty.jar, not valid.jar).

What Was Fixed

• Wrap the per-entry FS open + walkFileTree in try { … } catch (ZipException) { log.warn } catch (IOException) { log.warn } so a bad jar is skipped and indexing continues.
• New UX: collect the skipped jars (JarFsClasspathReader.unreadableJars → ModuleProject.unreadableClasspathJars) and, after indexing, surface a user-visible Flashbar from ProjectManagerImpl naming the dependency + a recovery path ("Sync the project to re-download dependencies") instead of a silent skip. Layering preserved (low-level reader only collects; orchestrator reports).

Testing

:subprojects:projects:testV8DebugUnitTest --tests …JarFsClasspathReaderCorruptJarTest → 2/2 green (red on baseline). Local CodeRabbit review: 1 major — the unreadableJars getter should return a defensive copy (_unreadableJars.toList()) to avoid handing out the backing list that's cleared on the next call. (Corroborated by local review; will address.)

---

Fixes APPDEVFORALL-Y8

[coderabbitai]

Warning

Review limit reached

@fryanpan, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 27 minutes and 37 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c190dbcd-0399-40ad-9fb9-16f7b9a15f37

📥 Commits

Reviewing files that changed from the base of the PR and between d73ec0b and 6c0c0fc.

📒 Files selected for processing (4)

• subprojects/projects/src/main/java/com/itsaky/androidide/projects/ProjectManagerImpl.kt
• subprojects/projects/src/main/java/com/itsaky/androidide/projects/api/ModuleProject.kt
• subprojects/projects/src/main/java/com/itsaky/androidide/projects/classpath/JarFsClasspathReader.kt
• subprojects/projects/src/test/java/com/itsaky/androidide/projects/classpath/JarFsClasspathReaderCorruptJarTest.kt

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-3364-zipexception-corrupt-jar-indexing

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Daniel-ADFA]

Approving with nitpick

[Daniel-ADFA]

please move user facing string to resource/string.xml

Suggested change

	flashError(
	flashError(R.string.xxx)