chore(controller): close phase 0 — lint gate + YAML parser test#11
Merged
Conversation
Tie up the remaining Phase 0 guardrail items. - Lint is now a hard gate for :app: abortOnError=true plus a committed lint-baseline.xml (existing backlog grandfathered, NEW issues fail), and the CI lint step drops continue-on-error. Addresses M11. - Extract the local_vars.yml flag reader out of DeployFragment into a pure, unit-tested util/LocalVarsYamlParser (LocalVarsYamlParserTest); DeployFragment delegates to it. Covers the "YAML parser" test item and is the first step on tech-debt D14 (replace the naive split-on-':' with a real parser later). - CI: stop the redundant double-run (push now only on main/development, not every branch; PRs are covered by the pull_request trigger), add a concurrency group that cancels superseded in-flight runs, and enable the Gradle build cache + parallel modules (org.gradle.caching/parallel) so unchanged inputs (e.g. a docs-only PR) can skip the slow lint analysis. - Docs: TECH_DEBT_PLAN progress log updated. Records that LogManager.getFormattedSize is Android-coupled (formatting already covered by the tested ByteFormatter) and InstallationPlanner OS sizing moved into the rootfs domain, so neither needs a separate test; and that K2/K6 are superseded/cosmetic.
…ingTranslation to warning Adds fr/hi/pt/ru for install_* (offline UX) and rsync_error_invalid_credentials (S1); en+es-only strings were breaking the now-blocking lint. MissingTranslation downgraded to non-blocking warning so secondary-locale gaps don't fail CI going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tie up the remaining Phase 0 guardrail items.