fix(dashboard): proot-safe copy (cp -a) instead of rsync -Aax#29
Merged
Conversation
rsync sets perms without following symlinks via lchmod = fchmodat(AT_SYMLINK_NOFOLLOW); glibc >=2.39 (Debian trixie 2.41) services that with the fchmodat2() syscall (Linux >=6.6). proot does not translate fchmodat2's path arg, so under proot on a 6.6+ kernel the guest path reaches the host untranslated and chmod returns ENOENT -> rsync exits 23 -> install_iiaboa_dashboard aborts (set -e) -> rootfs lacks flag_install_ready and the dashboard never starts. Reproduced building the rootfs off-device on a Raspberry Pi 5 (kernel 6.8) for BOTH armeabi-v7a and arm64-v8a; it worked on kernel 6.1 hosts and in the APK -> host-kernel-dependent, not arch-specific. cp uses plain chmod (old fchmodat), which proot translates, so the copy is reliable. Device-to-device sync is unaffected: its rsync is the static librsync.so built with lchmod disabled (ac_cv_func_lchmod=no), so it never calls fchmodat2.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rsync sets perms without following symlinks via lchmod = fchmodat(AT_SYMLINK_NOFOLLOW); glibc >=2.39 (Debian trixie 2.41) services that with the fchmodat2() syscall (Linux
Device-to-device sync is unaffected: its rsync is the static librsync.so built with lchmod disabled (ac_cv_func_lchmod=no), so it never calls fchmodat2.