fix(backup): make no-checksum / no-manifest transparency actually visible#44
Merged
Merged
Conversation
…t + restore) Pre-existing UX bug from the integrity PR (#37), surfaced after the #43 carve: - Import: the install_warn_no_checksum / install_warn_manifest_missing snackbar was immediately replaced by the unconditional install_msg_import_success Snackbar (Snackbar replaces, never queues) -> user never saw it. Now ONE snackbar: the warn strings (which already begin with 'Imported') become the final message when applicable. - Restore: no transparency was shown at all (it was only wired at the import gate). The restore log now leads with the no-checksum/no-manifest note, read cheaply from the identity manifest (origin=device-backup). The meaningful moment for the user. No new strings/imports; behaviour-only fix in BackupController.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour-only fix in
BackupController(one file). Pre-existing UX bug from the integrity work (#37), spotted after the #43 carve and confirmed on-device.Problem
install_warn_no_checksum/install_warn_manifest_missingsnackbar was shown, then immediately replaced by the unconditionalinstall_msg_import_successsnackbar (Snackbar replaces, never queues) → the user never saw the transparency note.Fix
OK_NO_CHECKSUM/OK_NO_MANIFEST, else the normal success.origin:"device-backup"). A builder rootfs with a real checksum shows neither (correct). A persistent surface, so it's not a fleeting snackbar.No new strings or imports. Verified locally by Luis (build + on-device: restore log shows the note; import shows a single snackbar).
Noted as pending (out of scope here)
Hardcoded "IIAB" in user-facing strings + a full
strings.xmlbrand audit (rebranding), restore-specific wording, and snackbar-duration review — tracked inREBRANDING_PLAN.md.