refactor(deploy): extract Planner into PlannerController [ADFA-4434]#48
Merged
Merged
Conversation
PR 1 of ADFA-4434 (decompose DeployFragment; epic ADFA-1028). Strangler-fig, no behaviour change. - New install/presentation/PlannerController (non-Fragment): tier selection, module checkbox grid, storage-size projection (RootfsViewModel + the LiveData observe()), and the Kiwix settings dialog. Moves ~407 LOC off the Fragment, incl. the observe() the lint detector walks. - New install/presentation/PlannerHost: seam the Fragment implements. 'What to install' state (selectedTier, module checkboxes, kiwix overrides, isStorageSafe) stays in the Fragment via the host; updateDynamicButtons + install-action are untouched. Controller owns only rootfsViewModel. - DeployFragment delegates via plannerController.bind(...) + createModulesGrid(); 3032 -> 2052 LOC (after the earlier backup carve, 2441 -> 2052 here). - Lint detectors stay disabled (install-action still in the Fragment). Verified: brace/paren balance, no dangling refs, no unprefixed Fragment calls, import scan clean. NOT yet built locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADFA-4434 (PR 1 of 2) · Epic ADFA-1028. Strangler-fig, no behaviour change.
Decomposes the
DeployFragmentgod class toward re-enabling the Fragment lint detectors disabled in #36.What
install/presentation/PlannerController(non-Fragment): tier selection, the module checkbox grid, the storage-size projection (RootfsViewModel+ the LiveDataobserve()), and the Kiwix settings dialog. ~407 LOC moved off the Fragment — including theobserve()the detector walks.install/presentation/PlannerHost: the seam the Fragment implements. "What to install" state (selectedTier, module checkboxes, kiwix overrides,isStorageSafe) stays in the Fragment via the host;updateDynamicButtonsand the install-action are untouched. The controller owns onlyrootfsViewModel.DeployFragmentdelegates viaplannerController.bind(...)+createModulesGrid(). 2441 → 2052 LOC.Scope
Lint detectors stay disabled (install-action still in the Fragment; that's PR 2 →
InstallController). Follows the backup carve (#43).Not in scope
Unrelated module-install regression seen on device (
Ansible: /dev/shm→ install ends in ~5s, falsely marked installed) is a pre-existing bug in the install execution (not touched here); tracked separately.