[Fix] Collision checker concurrent handling#78
Open
shivang1234gupta wants to merge 1 commit intoappform-io:mainfrom
Open
[Fix] Collision checker concurrent handling#78shivang1234gupta wants to merge 1 commit intoappform-io:mainfrom
shivang1234gupta wants to merge 1 commit intoappform-io:mainfrom
Conversation
r0goyal
reviewed
Oct 13, 2025
| import java.util.concurrent.Callable; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.*; | ||
| import java.util.concurrent.*; |
Contributor
There was a problem hiding this comment.
Revert wildcard imports with individual imports. This would raise issues on sonar
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue in concurrent execution of collisionChecker
Example:
Thread t1 get the time Xms, Just before the collisionChecker the clock moved to X+1ms
At the same time thread t2 with current time X+1ms started the collisionChecker, Thread t2 will update the currentInstant to X+1
When thread t1 will execute collisionChecker post t2 it will again reset the currentInstant to X, which will reset the bitset and ID collisions will happen for both X as well as X+1 bucket.
For eg -: Last Id = 0E2509151738525100023932
Duplicated Id = 0E2509151738525080023432, This issue will occur if bitset is resetted