Open
Conversation
|
r0goyal
requested changes
Apr 3, 2026
| * | ||
| * @param node the node identifier to use | ||
| */ | ||
| public static void initialize(int node) { |
Contributor
There was a problem hiding this comment.
This method may not be needed since this method was used only in bundle class (internal to this lib)
| )); | ||
|
|
||
| public static Optional<Integer> findValue(final IdFormatter formatter, final List<IdDecorator> decorators) { | ||
| val safeDecorators = decorators != null ? decorators : List.of(); |
Contributor
There was a problem hiding this comment.
Under what scenario do we expect list of decorators to be null ?
| */ | ||
| @Override | ||
| public Optional<String> parse(final String idString) { | ||
| val matcher = PATTERN.matcher(idString); |
Contributor
There was a problem hiding this comment.
Base36 decorator should only care about decoding from base36 to base10 and not about the format of overall ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


We have introduced the V2 version of IDFormatters which works on IDs which have prefix only with Alphabets. Going forward we are introducing construct of suffix appending in the IDs generated.
Why Suffix Needed?
This change is introduced to support business isolation use case where ID holds the custom logic in suffix to decide which zone to route this transaction.
Formatters Introduced -
Parses -