fix(social_share): android facebook sdk initialize method is deprecated and causing invalid facebook app id#192
Open
brams-9 wants to merge 1 commit intoappinioGmbH:mainfrom
Conversation
…ed and causing invalid facebook app id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
currently in
packages/appinio_social_share/android/src/main/java/com/appinio/socialshare/appinio_social_share/utils/SocialShareUtil.javamethodshareToFacebookcontain logic to triggerFacebookSdk.initialize()that automatically setup the facebook app id, but currently i encountered issue in android 11+ everytimeshareToFacebookis triggered, it always return error valid facebook app id must be supplied and i already make sure i already setup myandroidManifest.xmlcorrectly.as mentioned in this issues link #133
Root Cause
i've been tinkering for a while and found the root cause is in
FacebookSdk.initialize()method, that method is already deprecated and failed to automatically set the facebook app id for android 11+Solution
we need to set the facebook app id manually in order to fix this, so i omit
FacebookSdk.initialize()and addFacebookSdk.setApplicationId();to imperatively set facebook app id.