Remove url in the iOS Twitter share feature#292
Open
brokensandbox wants to merge 1 commit intoappinioGmbH:mainfrom
Open
Remove url in the iOS Twitter share feature#292brokensandbox wants to merge 1 commit intoappinioGmbH:mainfrom
brokensandbox wants to merge 1 commit intoappinioGmbH:mainfrom
Conversation
Contributor
|
could you add another method for the URL handling, as proposed in the initial comment? Thx a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For iOS Twitter sharing, the text string is used twice, once as initial text, and another time as url. If the text is not a URL, then the tweet has 2 lines of text, first line as plain text, and second line as URL encoded string. I think it makes more sense to remove setting the text as URL in this method, and URL content could be supported separately in a different method.