feat: add optional linkText and linkUrl to shareToInstagramStory()#330
Open
juandelgado wants to merge 1 commit intoappinioGmbH:mainfrom
Open
feat: add optional linkText and linkUrl to shareToInstagramStory()#330juandelgado wants to merge 1 commit intoappinioGmbH:mainfrom
juandelgado wants to merge 1 commit intoappinioGmbH:mainfrom
Conversation
juandelgado
requested review from
bilalhamud and
khanmujeeb687
as code owners
|
Can someone merge? |
|
iOS is working. Android not. (no error, just no link) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for optional
linkTextandlinkUrlparameters when sharing to Instagram stories.With these parameters Instagram renders a sticker in the middle of the story with the text and URL provided. I wish I could link to the official documentation but unfortunately I have not been able to find it yet. I'm only following how this was implemented in the React Native Share repository.
I've tested it on iOS but it could do with some testing on Android too.
Hope it helps.
PS: the reason I ended up looking at
linkTextandlinkUrlis becauseattributionUrldoes not seem to have any effect at all.